Remove darken lighten (PR #10330)

Here I remove instances of darken() or lighten() color functions from the following files, as well as create new hover variables for $tertiary, $danger, $success, and the social colors.

These examples show that there is little to no difference by switching to a method that does not use these color functions.

  1. compose.scss image

  2. emoji.scss changes bg-hover color of emoji when selecting

image

  1. topic-admin-menu.scss changes active/hover color on select posts menu buttons

New

Old

  1. buttons.scss changes buttons hover/active image

GitHub

This looks very nice!

The only thing I would check is the dark scheme colors, especially for the buttons it would be good to review the before/after.

This looks very nice!

The only thing I would check is the dark scheme colors, especially for the buttons it would be good to review the before/after.

Dark Buttons

There is a difference in the active state here for sure.

Yes I see the difference in the active state, but that looks good to me.

I don’t love the active state on the default buttons in dark theme… it’s kind of the inverse of what it should be, but I think it’s fine to move forward with.