Remove the last set of `Discourse.SiteSettings` (PR #10298)

After this commit the entire Discourse application and test suite should run without using the global Discourse.SiteSettings object.

GitHub

This pull request introduces 1 alert when merging 5301f32e748fe4811eb480be0d262cd49c023424 into 20dc845418e13d23423fb986dc0fc10cdc07234a - view on LGTM.com

new alerts:

  • 1 for Useless conditional