Revert "DEV: add routes_lazy_route to boost boot-up time (#14545)" (#14581)

Revert “DEV: add routes_lazy_route to boost boot-up time (#14545)” (#14581)

This reverts commit f5cf647e579d6a2c844a38d695877e5aad951184.

The gem breaks usage of Rails URL helpers when used outside views and controllers, for example in https://github.com/discourse/discourse/blob/88ecb83382e4dc5cec1d9599619a6c40a07825ae/app/models/upload.rb#L239-L242 the upload_short_path method call fails with an undefined method exception when this gem is enabled.

diff --git a/Gemfile b/Gemfile
index bb70ee2..e09839e 100644
--- a/Gemfile
+++ b/Gemfile
@@ -151,7 +151,6 @@ group :test do
 end
 
 group :test, :development do
-  gem 'routes_lazy_routes'
   gem 'rspec'
   gem 'mock_redis'
   gem 'listen', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 9d1e0c3..3244e72 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -352,9 +352,6 @@ GEM
     rexml (3.2.5)
     rinku (2.0.6)
     rotp (6.2.0)
-    routes_lazy_routes (0.4.2)
-      actionpack
-      railties
     rqrcode (2.1.0)
       chunky_png (~> 1.0)
       rqrcode_core (~> 1.0)
@@ -581,7 +578,6 @@ DEPENDENCIES
   redis-namespace
   rinku
   rotp
-  routes_lazy_routes
   rqrcode
   rspec
   rspec-html-matchers
diff --git a/app/jobs/base.rb b/app/jobs/base.rb
index 0dbf9fc..fdcd1dd 100644
--- a/app/jobs/base.rb
+++ b/app/jobs/base.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'sidekiq/api'
-
 module Jobs
 
   def self.queued

GitHub sha: 228264d17c9a5f56c90063c6fc6b51421c4b0d28

This commit appears in #14581 which was approved by davidtaylorhq. It was merged by OsamaSayegh.

FYI @amatsuda