Revert "FIX: Auth popup handling for Safari same-site cookie quirks"

Revert “FIX: Auth popup handling for Safari same-site cookie quirks”

This reverts commit 310a8ac2427978779c1bb31f71321bfb84688336.

It seems this breaks google authentication. My suspicion is opening the URL twice invalidates the CSRF after the first access.

diff --git a/app/assets/javascripts/discourse/models/login-method.js.es6 b/app/assets/javascripts/discourse/models/login-method.js.es6
index 83e9a18..0b12604 100644
--- a/app/assets/javascripts/discourse/models/login-method.js.es6
+++ b/app/assets/javascripts/discourse/models/login-method.js.es6
@@ -53,7 +53,7 @@ const LoginMethod = Ember.Object.extend({
         }
         LoginMethod.buildPostForm(authUrl).then(form => {
           const windowState = window.open(
-            authUrl,
+            "about:blank",
             "auth_popup",
             `menubar=no,status=no,height=${height},width=${width},left=${left},top=${top}`
           );

GitHub sha: 3e3f6b1b

1 Like