Revert "FIX: make full height menu and cloak respect custom headers"

Revert “FIX: make full height menu and cloak respect custom headers”

This reverts commit a61d9deba192a54333007ec838dc5c8e1fa857fc.

diff --git a/app/assets/javascripts/discourse/components/site-header.js.es6 b/app/assets/javascripts/discourse/components/site-header.js.es6
index 815d323..ab765a0 100644
--- a/app/assets/javascripts/discourse/components/site-header.js.es6
+++ b/app/assets/javascripts/discourse/components/site-header.js.es6
@@ -367,7 +367,7 @@ const SiteHeaderComponent = MountWidget.extend(Docking, PanEvents, {
           $headerCloak.show();
         }
 
-        const menuTop = this.site.mobileView ? headerTop() : headerHeight();
+        const menuTop = this.site.mobileView ? 0 : headerHeight();
 
         let height;
         const winHeightOffset = 16;
@@ -386,7 +386,6 @@ const SiteHeaderComponent = MountWidget.extend(Docking, PanEvents, {
         }
         if (style.top !== menuTop + "px" || style.height !== height) {
           $panel.css({ top: menuTop + "px", height });
-          $(".header-cloak").css({ top: menuTop + "px" });
         }
         $("body").removeClass("drop-down-mode");
       }
@@ -435,9 +434,3 @@ export function headerHeight() {
     $header.outerHeight() + headerOffsetTop - $(window).scrollTop()
   );
 }
-
-export function headerTop() {
-  const $header = $("header.d-header");
-  const headerOffset = $header.offset();
-  return headerOffset ? headerOffset.top : 0;
-}

GitHub
sha: e8a75628

note … we had to do this cause it was causing rendering issues on mobile…

1 Like