Revert "PERF: Prefer joins over subquery for `User#private_posts_for_user`."

Revert “PERF: Prefer joins over subquery for User#private_posts_for_user.”

This reverts commit 05b43e5ae45fed10742de0829e579880098adcf7.

diff --git a/app/models/post.rb b/app/models/post.rb
index afaea02..e07a78f 100644
--- a/app/models/post.rb
+++ b/app/models/post.rb
@@ -80,10 +80,7 @@ class Post < ActiveRecord::Base
   register_custom_field_type(MISSING_UPLOADS_IGNORED, :boolean)
 
   scope :private_posts_for_user, ->(user) {
-    joins("LEFT JOIN topic_allowed_users ON topic_allowed_users.topic_id = posts.topic_id AND topic_allowed_users.user_id = #{user.id.to_i}")
-      .joins("LEFT JOIN group_users ON group_users.user_id = #{user.id.to_i}")
-      .joins("LEFT JOIN topic_allowed_groups ON topic_allowed_groups.topic_id = posts.topic_id AND topic_allowed_groups.group_id = group_users.group_id")
-      .where("topic_allowed_users.topic_id IS NOT NULL OR topic_allowed_groups.topic_id IS NOT NULL")
+    where("posts.topic_id IN (#{Topic::PRIVATE_MESSAGES_SQL})", user_id: user.id)
   }
 
   scope :by_newest, -> { order('created_at DESC, id DESC') }

GitHub sha: 872ef82f

Decided this was risky security wise so pushing it to a PR https://github.com/discourse/discourse/pull/10452

1 Like