REVERT: revert change from action + mut to mut (#10844)

REVERT: revert change from action + mut to mut (#10844)

  • Revert “FIX: fixes regression where wizard dropdown couldn’t update (#10838)”

This reverts commit e3b2fc60749ca3b584955d13a02cbe7f783a90a7.

  • Revert “DEV: replaces unecessary (action (mut .)) by (mut .) (#10822)”

This reverts commit c0350dc362ce97af7424e8b7b93113a0a2e50510.

diff --git a/app/assets/javascripts/admin/addon/templates/badges-show.hbs b/app/assets/javascripts/admin/addon/templates/badges-show.hbs
index 1c88e9e..49741c8 100644
--- a/app/assets/javascripts/admin/addon/templates/badges-show.hbs
+++ b/app/assets/javascripts/admin/addon/templates/badges-show.hbs
@@ -17,7 +17,7 @@
         options=(hash
           maximum=1
         )
-        onChange=(fn (mut buffered.icon))
+        onChange=(action (mut buffered.icon))
       }}
 
       <p class="help">{{i18n "admin.badges.icon_help"}}</p>
@@ -35,7 +35,7 @@
         name="badge_type_id"
         value=buffered.badge_type_id
         content=badgeTypes
-        onChange=(fn (mut buffered.badge_type_id))
+        onChange=(action (mut buffered.badge_type_id))
         isDisabled=readOnly
       }}
     </div>
@@ -50,7 +50,7 @@
           content=badgeGroupings
           class="badge-selector"
           nameProperty="name"
-          onChange=(fn (mut buffered.badge_grouping_id))
+          onChange=(action (mut buffered.badge_grouping_id))
         }}
         {{d-button
           class="btn-default"
@@ -112,7 +112,7 @@
             name="trigger"
             value=buffered.trigger
             content=badgeTriggers
-            onChange=(fn (mut buffered.trigger))
+            onChange=(action (mut buffered.trigger))
             disabled=readOnly
           }}
         </div>
diff --git a/app/assets/javascripts/admin/addon/templates/components/admin-user-field-item.hbs b/app/assets/javascripts/admin/addon/templates/components/admin-user-field-item.hbs
index 7414446..211cc00 100644
--- a/app/assets/javascripts/admin/addon/templates/components/admin-user-field-item.hbs
+++ b/app/assets/javascripts/admin/addon/templates/components/admin-user-field-item.hbs
@@ -3,7 +3,7 @@
     {{combo-box
       content=fieldTypes
       value=buffered.field_type
-      onChange=(fn (mut buffered.field_type))
+      onChange=(action (mut buffered.field_type))
     }}
   {{/admin-form-row}}
 
diff --git a/app/assets/javascripts/admin/addon/templates/components/embeddable-host.hbs b/app/assets/javascripts/admin/addon/templates/components/embeddable-host.hbs
index 1ed3212..7d73d93 100644
--- a/app/assets/javascripts/admin/addon/templates/components/embeddable-host.hbs
+++ b/app/assets/javascripts/admin/addon/templates/components/embeddable-host.hbs
@@ -16,7 +16,7 @@
     {{category-chooser
       value=categoryId
       class="small"
-      onChange=(mut categoryId)
+      onChange=(action (mut categoryId))
     }}
   </td>
   <td class="editing-controls">
diff --git a/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs b/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs
index f8ec83b..8792d78 100644
--- a/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs
+++ b/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs
@@ -11,7 +11,7 @@
 {{combo-box
   content=permalinkTypes
   value=permalinkType
-  onChange=(mut permalinkType)
+  onChange=(action (mut permalinkType))
   class="permalink-type"
 }}
 
diff --git a/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs b/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs
index aa9da28..488c14f 100644
--- a/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs
+++ b/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs
@@ -4,7 +4,7 @@
 {{combo-box
   content=actionNames
   value=actionName
-  onChange=(mut actionName)
+  onChange=(action (mut actionName))
 }}
 
 {{d-button class="btn-default" action=(action "submit") disabled=formSubmitted label="admin.logs.screened_ips.form.add"}}
diff --git a/app/assets/javascripts/admin/addon/templates/components/site-settings/category.hbs b/app/assets/javascripts/admin/addon/templates/components/site-settings/category.hbs
index 089e590..80a7938 100644
--- a/app/assets/javascripts/admin/addon/templates/components/site-settings/category.hbs
+++ b/app/assets/javascripts/admin/addon/templates/components/site-settings/category.hbs
@@ -1,7 +1,7 @@
 {{category-chooser
   value=value
   allowUncategorized=true
-  onChange=(mut value)
+  onChange=(action (mut value))
 }}
 {{setting-validation-message message=validationMessage}}
 <div class="desc">{{html-safe setting.description}}</div>
diff --git a/app/assets/javascripts/admin/addon/templates/components/site-settings/enum.hbs b/app/assets/javascripts/admin/addon/templates/components/site-settings/enum.hbs
index be5f5cc..265301d 100644
--- a/app/assets/javascripts/admin/addon/templates/components/site-settings/enum.hbs
+++ b/app/assets/javascripts/admin/addon/templates/components/site-settings/enum.hbs
@@ -1,7 +1,7 @@
 {{combo-box
   content=setting.validValues
   value=value
-  onChange=(mut value)
+  onChange=(action (mut value))
   valueProperty=setting.computedValueProperty
   nameProperty=setting.computedNameProperty
   options=(hash
diff --git a/app/assets/javascripts/admin/addon/templates/modal/admin-color-scheme-select-base.hbs b/app/assets/javascripts/admin/addon/templates/modal/admin-color-scheme-select-base.hbs
index 0d18c26..15a3931 100644
--- a/app/assets/javascripts/admin/addon/templates/modal/admin-color-scheme-select-base.hbs
+++ b/app/assets/javascripts/admin/addon/templates/modal/admin-color-scheme-select-base.hbs
@@ -4,7 +4,7 @@
     {{combo-box
       content=model
       value=selectedBaseThemeId
-      onChange=(mut selectedBaseThemeId)
+      onChange=(action (mut selectedBaseThemeId))
       valueProperty="base_scheme_id"
     }}
   {{/d-modal-body}}
diff --git a/app/assets/javascripts/admin/addon/templates/modal/admin-install-theme.hbs b/app/assets/javascripts/admin/addon/templates/modal/admin-install-theme.hbs
index d0c607b..053ce04 100644
--- a/app/assets/javascripts/admin/addon/templates/modal/admin-install-theme.hbs
+++ b/app/assets/javascripts/admin/addon/templates/modal/admin-install-theme.hbs
@@ -93,7 +93,7 @@
           valueProperty="value"
           content=createTypes
           value=selectedType
-          onChange=(mut selectedType)
+          onChange=(action (mut selectedType))
         }}
       </div>
     {{/if}}
diff --git a/app/assets/javascripts/admin/addon/templates/search-logs-index.hbs b/app/assets/javascripts/admin/addon/templates/search-logs-index.hbs
index aafdf2a..baf5164 100644
--- a/app/assets/javascripts/admin/addon/templates/search-logs-index.hbs
+++ b/app/assets/javascripts/admin/addon/templates/search-logs-index.hbs
@@ -1,10 +1,10 @@
 <div class="admin-title">
-  {{period-chooser period=period onChange=(mut period)}}
+  {{period-chooser period=period onChange=(action (mut period))}}
   {{combo-box
     content=searchTypeOptions
     value=searchType
     class="search-logs-filter"
-    onChange=(mut searchType)
+    onChange=(action (mut searchType))
   }}
 </div>
 
diff --git a/app/assets/javascripts/admin/addon/templates/search-logs-term.hbs b/app/assets/javascripts/admin/addon/templates/search-logs-term.hbs
index 43753b1..b4b0c8a 100644
--- a/app/assets/javascripts/admin/addon/templates/search-logs-term.hbs
+++ b/app/assets/javascripts/admin/addon/templates/search-logs-term.hbs
@@ -1,10 +1,10 @@
 <div class="admin-title">
-  {{period-chooser period=period onChange=(mut period)}}
+  {{period-chooser period=period onChange=(action (mut period))}}
   {{combo-box
     content=searchTypeOptions
     value=searchType
     class="search-logs-filter"
-    onChange=(mut searchType)
+    onChange=(action (mut searchType))
   }}
 </div>
 
diff --git a/app/assets/javascripts/admin/addon/templates/user-badges.hbs b/app/assets/javascripts/admin/addon/templates/user-badges.hbs
index ecf30a1..a5e6664 100644
--- a/app/assets/javascripts/admin/addon/templates/user-badges.hbs
+++ b/app/assets/javascripts/admin/addon/templates/user-badges.hbs
@@ -20,7 +20,7 @@
             filterable=true

[... diff too long, it was truncated ...]

GitHub sha: 7b34433f

This commit appears in #10844 which was approved by davidtaylorhq. It was merged by jjaffeux.

This commit has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/dropdowns-broken/166438/7