Should we allow someone to approve their own commit?

I guess the point of this is to get our commits reviewed by at least another person, so it would not make sense for someone to approve their own commit, right?

Maybe we should hide the :+1: Approve on your own commits?

I implemented this yesterday and then didn’t push it cause I thought of a few edge cases, in particular perhaps it was already reviewed in a PR or already being followed up

That said happy to try it out for a few days and see how painful it gets, we are all over the queue

Maybe make a site setting?

1 Like

I don’t see why those can’t be approved by another person :wink:

The only way to know if it’s a good or bad idea :dog:

That’s always an option.

2 Likes

Site setting is in the house…

1 Like