Upgrade node to v10 for test and dev

Upgrade node to v10 for test and dev

This fixes the following error during image build:

sane@4.0.2: The engine “node” is incompatible with this module. Expected version “6.* || 8.* || >= 10.*”. Got “9.11.2”

diff --git a/image/discourse_dev/Dockerfile b/image/discourse_dev/Dockerfile
index c8b3623..28ee6fb 100644
--- a/image/discourse_dev/Dockerfile
+++ b/image/discourse_dev/Dockerfile
@@ -42,7 +42,7 @@ RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | sudo ap
     echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list &&\
     curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add - &&\
     echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list &&\
-    curl -sL https://deb.nodesource.com/setup_9.x | sudo -E bash - &&\
+    curl -sL https://deb.nodesource.com/setup_10.x | sudo -E bash - &&\
     apt-get update &&\
     apt-get install -y google-chrome-stable yarn nodejs &&\
     npm install -g eslint babel-eslint
diff --git a/image/discourse_test/Dockerfile b/image/discourse_test/Dockerfile
index 2070539..08d0476 100644
--- a/image/discourse_test/Dockerfile
+++ b/image/discourse_test/Dockerfile
@@ -17,7 +17,7 @@ RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | sudo ap
     echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list &&\
     curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add - &&\
     echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list &&\
-    curl -sL https://deb.nodesource.com/setup_9.x | sudo -E bash - &&\
+    curl -sL https://deb.nodesource.com/setup_10.x | sudo -E bash - &&\
     apt-get update &&\
     apt-get install -y libgconf-2-4 google-chrome-stable yarn nodejs &&\
     npm install -g eslint babel-eslint &&\

GitHub sha: 2da30c24

1 Like

Version 9 had its EOL on 2018-06-30, so we were bound to see errors sooner or later.

The base image is still on version 8 (LTS Maintenance Release) which should be supported until December 2019.