UX: add height attribute to logo on error pages

UX: add height attribute to logo on error pages

This matches what we do in the home-logo widget. The height is set as an attribute and we use CSS to get a scaled width that preserves the aspect ratio of the image.

From e2214b50f34c22d44645c641968acb89f81287dc Mon Sep 17 00:00:00 2001
From: Joe <33972521+hnb-ku@users.noreply.github.com>
Date: Fri, 23 Nov 2018 15:04:34 +0800
Subject: [PATCH] UX: add height attribute to logo on error pages

This matches what we do in the home-logo widget. The height is set as an attribute and we use CSS to get a scaled width that preserves the aspect ratio of the image.

diff --git a/app/views/application/_header.html.erb b/app/views/application/_header.html.erb
index 82305d1..24f6cb6 100644
--- a/app/views/application/_header.html.erb
+++ b/app/views/application/_header.html.erb
@@ -3,10 +3,10 @@
     <div class="wrap">
       <div class="contents">
         <div class="row">
-          <div class="title span13">
+          <div class="logo-wrapper">
             <a href="<%= path "/" %>">
               <%- if application_logo_url.present? %>
-                <img src="<%= application_logo_url %>" alt="<%= SiteSetting.title %>" id="site-logo">
+                <img src="<%= application_logo_url %>" height="36" alt="<%= SiteSetting.title %>" id="site-logo">
               <%- else %>
                 <h2 id='site-text-logo'><%= SiteSetting.title %></h2>
               <%- end %>

GitHub

This commit has been mentioned on Discourse Meta. There might be relevant details there: