UX: adds visual feedback to topic-notifications-button (PR #8892)

GitHub

You’ve signed the CLA, jjaffeux. Thank you! This pull request is ready for review.

Why do we need the 250ms delay here?

Sorry forgot to answer, this is to have a consistent loading animation. Often the loading is so fast that you barely see it and end up just having a blinking/clunky UI. Given this is only for animation purpose and doesn’t block UI I think it’s fine to always have this delay.

Sounds good to me. Thanks for the clarification.

@jjaffeux looks like we have conflict :frowning: can you fix and merge this, change looks pretty safe to me.

@SamSaffron I want to try a better a solution, this is why I postponed merged for now.

I worry that we are keeping this open for too long @jjaffeux closing for now pending a new PR