UX: always display remove emoji btn from emoji-value-list (#12652)

UX: always display remove emoji btn from emoji-value-list (#12652)

Although if emoji is not editable it should be disabled.

diff --git a/app/assets/javascripts/admin/addon/templates/components/emoji-value-list.hbs b/app/assets/javascripts/admin/addon/templates/components/emoji-value-list.hbs
index aeed56f..d1843a2 100644
--- a/app/assets/javascripts/admin/addon/templates/components/emoji-value-list.hbs
+++ b/app/assets/javascripts/admin/addon/templates/components/emoji-value-list.hbs
@@ -2,14 +2,13 @@
   <ul class="values emoji-value-list">
     {{#each collection as |data index|}}
       <li class="value" data-index={{index}}>
-        {{#if data.isEditable}}
-          {{d-button
-            action=(action "removeValue")
-            actionParam=data
-            icon="times"
-            class="remove-value-btn btn-small"
-          }}
-        {{/if}}
+        {{d-button
+          action=(action "removeValue")
+          actionParam=data
+          icon="times"
+          class="remove-value-btn btn-small"
+          disabled=(not data.isEditable)
+        }}
 
         <div class="value-input emoji-details {{if data.isEditable "can-edit"}} {{if data.isEditing "d-editor-textarea-wrapper"}}" {{on "click" (fn this.editValue index)}} role="button">
           <img height="15px" width="15px" src={{data.emojiUrl}} class="emoji-list-emoji">

GitHub sha: 6081f8e5

This commit appears in #12652 which was approved by CvX. It was merged by jjaffeux.