UX: Better composer hyperlink modal (PR #8160)

This brings the hyperlink modal in line with all other modals (upload, date, etc.) by placing the fixed modal element outside of the composer.

Before:

image

After:

image

GitHub

1 Like

You’ve signed the CLA, pmusaraj. Thank you! This pull request is ready for review.

Does it have to be a computed property if the value is static?

2 Likes

Good spot, no, it doesn’t need to be computed at all.

ESLint error, computed is no longer used: Travis CI - Test and Deploy Your Code with Confidence

I support this cleanup, feel free to merge!

@pmusaraj It seems it’s no longer possible to submit the form by pressing enter/return. Could this PR be the cause?

Yes, it’s possible. I think our modals in general do not submit on return, I think we should fix that globally.

2 Likes

UX: Trigger primary action in modals using Enter should fix your issue @CvX.

3 Likes