UX: change text of public_topic action code in login required sites. (PR #14764)

The wording “made this topic public” made confusion in login required forums.

GitHub

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

I am trying to migrate us away from using Site as a global like this. Is there any way you can pass an instance of this.site from a component/controller through to the method and use that instead?