UX: consistent share modal & popup, refactoring (PR #13759)

There are similarities between this popup and modal, so I’ve merged some classes and styles and added some more consistency. There were also some alignment issues in the invite modal that I fixed. Plus this gets rid of the weird close button at the bottom of the share link popup.

Before, After

Screen Shot 2021-07-15 at 11 23 31 PM Screen Shot 2021-07-15 at 11 16 47 PM

Screen Shot 2021-07-15 at 11 24 12 PM Screen Shot 2021-07-15 at 11 17 32 PM

GitHub

Seems good but looks like a JS test is failing.

    font-size: var(--font-up-1);
{{d-button
  action=(action "share" source)
  class=(concat "btn-default share-" source.id)
  translatedTitle=source.title
  translatedAriaLabel=source.title
  icon=(if source.icon source.icon source.htmlIcon)
 }}

(While you’re at it)

yes! thank you

Looks great!

@awesomerobot, users browsing with uBlock Origin may not be able to see the link boxes after this change.

Screen Shot 2021-07-19 at 15 16 13

fanboy-social.txt (and fanboy-annoyance.txt) filter ##.share-link-container.

I am unsure whether we pay much attention to compatibility with ad blockers. uBO, with these rulesets, is in widespread use (at least outside Apple’s walled garden).

@saj no worries, changing the class name is an easy fix — I’ll get that updated today