UX: don't disable "create account" button & display error message for required fields. (PR #9643)

GitHub

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/not-obvious-that-you-need-to-scroll-down-during-signup/112971/16

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/you-have-not-completed-all-user-fields-ux-on-signup-should-be-improved/42376/7

this._super(…arguments);

We would need a more descriptive name for the action please, it’s doesn’t clash with native ember events (focusIn, focusOut) but still it would be safer.

would be worth storing the element lookup

I don’t know much all this code, but it looks like a smell to me to carry this component like this.

Also I see it’s used as “element” later, when most of the times these elements are DOM nodes, and not Ember components.

I’m using the name focus since I have to call it here. I need to add one more if condition if I change it.

@jjaffeux the requested changes are now completed.

Can you show me what it does please ?

@jjaffeux like in the below screenshots, instead of disabling the “Create Account” button it will show the error message when the form submitted.

Before After
image image