UX: Ensure external login icons are visible on hover (#13914)

UX: Ensure external login icons are visible on hover (#13914)

Some authentication buttons (e.g. apple, oidc, oauth2, saml) do not have a specific color specified. Therefore they were taking the default button-with-icon color, and the icons would almost disappear on hover. This commit adds a default of #000 for these buttons, so that the button hover looks similar to core auth buttons.

diff --git a/app/assets/stylesheets/common/components/buttons.scss b/app/assets/stylesheets/common/components/buttons.scss
index 82cc92e..8dd59fd 100644
--- a/app/assets/stylesheets/common/components/buttons.scss
+++ b/app/assets/stylesheets/common/components/buttons.scss
@@ -178,6 +178,10 @@
     margin-right: 9px;
     font-size: $font-0;
   }
+  .d-icon,
+  &.btn:hover .d-icon {
+    color: #000;
+  }
   &.google_oauth2 {
     background: var(--google);
     color: #333;

GitHub sha: ab1460e2ca65c12b1309442a88491a08f372b81c

This commit appears in #13914 which was approved by ZogStriP. It was merged by davidtaylorhq.