UX: homogenises sk row padding and topic-admin-menu (#9920)

UX: homogenises sk row padding and topic-admin-menu (#9920)

diff --git a/app/assets/stylesheets/common/base/topic-admin-menu.scss b/app/assets/stylesheets/common/base/topic-admin-menu.scss
index 3af52a2..a12e65f 100644
--- a/app/assets/stylesheets/common/base/topic-admin-menu.scss
+++ b/app/assets/stylesheets/common/base/topic-admin-menu.scss
@@ -2,7 +2,8 @@
 
 .topic-admin-popup-menu {
   @include breakpoint(mobile-extra-large) {
-    width: 100%;
+    width: calc(100% - 20px);
+    margin: 0 10px;
     padding: 0;
     padding-bottom: env(safe-area-inset-bottom);
     z-index: z("modal", "popover");
diff --git a/app/assets/stylesheets/common/select-kit/combo-box.scss b/app/assets/stylesheets/common/select-kit/combo-box.scss
index 863e9fc..d592023 100644
--- a/app/assets/stylesheets/common/select-kit/combo-box.scss
+++ b/app/assets/stylesheets/common/select-kit/combo-box.scss
@@ -8,7 +8,7 @@
     .select-kit-row {
       margin: 0;
       min-height: 1px;
-      padding: 6px 10px;
+
       &.no-content {
         font-weight: normal;
       }
@@ -53,7 +53,7 @@
           line-height: $line-height-medium;
           font-weight: bold;
           display: block;
-          padding: 6px 10px;
+          padding: 0.75em;
           color: $tertiary;
 
           &:hover {
diff --git a/app/assets/stylesheets/common/select-kit/dropdown-select-box.scss b/app/assets/stylesheets/common/select-kit/dropdown-select-box.scss
index 5221072..fa6e12d 100644
--- a/app/assets/stylesheets/common/select-kit/dropdown-select-box.scss
+++ b/app/assets/stylesheets/common/select-kit/dropdown-select-box.scss
@@ -21,7 +21,6 @@
 
     .select-kit-row {
       margin: 0;
-      padding: 10px 5px;
 
       .icons {
         display: -webkit-box;
diff --git a/app/assets/stylesheets/common/select-kit/mini-tag-chooser.scss b/app/assets/stylesheets/common/select-kit/mini-tag-chooser.scss
index 27c302e..b167d54 100644
--- a/app/assets/stylesheets/common/select-kit/mini-tag-chooser.scss
+++ b/app/assets/stylesheets/common/select-kit/mini-tag-chooser.scss
@@ -46,8 +46,14 @@
           background: $tertiary-low;
         }
 
+        .discourse-tag {
+          &:hover {
+            color: $primary;
+          }
+        }
+
         .discourse-tag-count {
-          margin-left: 5px;
+          margin-left: 0.5em;
         }
       }
 
diff --git a/app/assets/stylesheets/common/select-kit/select-kit.scss b/app/assets/stylesheets/common/select-kit/select-kit.scss
index a9769b5..f1c61c0 100644
--- a/app/assets/stylesheets/common/select-kit/select-kit.scss
+++ b/app/assets/stylesheets/common/select-kit/select-kit.scss
@@ -139,13 +139,13 @@
 
   .select-kit-row {
     cursor: pointer;
-    line-height: $line-height-medium;
     outline: none;
     display: flex;
     flex: 1 0 auto;
     box-sizing: border-box;
     align-items: center;
     justify-content: flex-start;
+    padding: 0.75em;
 
     .name {
       margin: 0;
diff --git a/app/assets/stylesheets/mobile/select-kit/dropdown-select-box.scss b/app/assets/stylesheets/mobile/select-kit/dropdown-select-box.scss
index 294b4a8..5d4c468 100644
--- a/app/assets/stylesheets/mobile/select-kit/dropdown-select-box.scss
+++ b/app/assets/stylesheets/mobile/select-kit/dropdown-select-box.scss
@@ -6,7 +6,3 @@
     }
   }
 }
-
-.select-kit.combo-box .select-kit-row {
-  padding: 10px;
-}
diff --git a/app/assets/stylesheets/mobile/topic.scss b/app/assets/stylesheets/mobile/topic.scss
index ae82843..f2fcdfd 100644
--- a/app/assets/stylesheets/mobile/topic.scss
+++ b/app/assets/stylesheets/mobile/topic.scss
@@ -241,16 +241,8 @@ sub sub {
       @media screen and (max-width: 550px) {
         grid-template-columns: 1fr 1fr;
       }
-      > div {
-        margin-right: 0.5em;
-        overflow: hidden;
-        &:nth-of-type(2) {
-          // move delete further from modal close
-          order: 12;
-        }
-        button {
-          @include ellipsis;
-        }
+      .popup-menu-btn {
+        @include ellipsis;
       }
     }
   }

GitHub sha: d7d5bb44

1 Like

This commit appears in #9920 which was merged by jjaffeux.