UX: Normalize sizing for inputs, buttons, dropdowns (#14226)

UX: Normalize sizing for inputs, buttons, dropdowns (#14226)

See PR for details

diff --git a/app/assets/javascripts/admin/addon/components/screened-ip-address-form.js b/app/assets/javascripts/admin/addon/components/screened-ip-address-form.js
index 5636c30..95ed9ed 100644
--- a/app/assets/javascripts/admin/addon/components/screened-ip-address-form.js
+++ b/app/assets/javascripts/admin/addon/components/screened-ip-address-form.js
@@ -17,7 +17,7 @@ import { schedule } from "@ember/runloop";
 **/
 
 export default Component.extend({
-  classNames: ["screened-ip-address-form"],
+  classNames: ["screened-ip-address-form", "inline-form"],
   formSubmitted: false,
   actionName: "block",
 
diff --git a/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs b/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs
index 8792d78..938c77b 100644
--- a/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs
+++ b/app/assets/javascripts/admin/addon/templates/components/permalink-form.hbs
@@ -1,30 +1,35 @@
-<b>{{i18n "admin.permalink.form.label"}}</b>
+<div class="inline-form">
+  <label>{{i18n "admin.permalink.form.label"}}</label>
 
-{{text-field
-  value=url
-  disabled=formSubmitted
-  class="permalink-url"
-  placeholderKey="admin.permalink.url"
-  autocorrect="off"
-  autocapitalize="off"}}
+  {{text-field
+    value=url
+    disabled=formSubmitted
+    class="permalink-url"
+    placeholderKey="admin.permalink.url"
+    autocorrect="off"
+    autocapitalize="off"
+  }}
 
-{{combo-box
-  content=permalinkTypes
-  value=permalinkType
-  onChange=(action (mut permalinkType))
-  class="permalink-type"
-}}
+  {{combo-box
+    content=permalinkTypes
+    value=permalinkType
+    onChange=(action (mut permalinkType))
+    class="permalink-type"
+  }}
 
-{{text-field
-  value=permalink_type_value
-  disabled=formSubmitted
-  class="external-url"
-  placeholderKey=permalinkTypePlaceholder
-  autocorrect="off"
-  autocapitalize="off"}}
+  {{text-field
+    value=permalink_type_value
+    disabled=formSubmitted
+    class="external-url"
+    placeholderKey=permalinkTypePlaceholder
+    autocorrect="off"
+    autocapitalize="off"
+  }}
 
-{{d-button
-  class="btn-default"
-  action=(action "submit")
-  disabled=formSubmitted
-  label="admin.permalink.form.add"}}
+  {{d-button
+    class="btn-default"
+    action=(action "submit")
+    disabled=formSubmitted
+    label="admin.permalink.form.add"
+  }}
+</div>
diff --git a/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs b/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs
index 488c14f..a78a6c8 100644
--- a/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs
+++ b/app/assets/javascripts/admin/addon/templates/components/screened-ip-address-form.hbs
@@ -1,4 +1,4 @@
-<b>{{i18n "admin.logs.screened_ips.form.label"}}</b>
+<label>{{i18n "admin.logs.screened_ips.form.label"}}</label>
 {{text-field value=ip_address disabled=formSubmitted class="ip-address-input" placeholderKey="admin.logs.screened_ips.form.ip_address" autocorrect="off" autocapitalize="off"}}
 
 {{combo-box
diff --git a/app/assets/javascripts/admin/addon/templates/email-index.hbs b/app/assets/javascripts/admin/addon/templates/email-index.hbs
index ddf914f..4919b24 100644
--- a/app/assets/javascripts/admin/addon/templates/email-index.hbs
+++ b/app/assets/javascripts/admin/addon/templates/email-index.hbs
@@ -16,21 +16,24 @@
 
 <form>
   <div class="admin-controls">
-    {{#if sendingEmail}}
-      <div class="controls">{{i18n "admin.email.sending_test"}}</div>
-    {{else}}
-      <div class="controls">
-        {{text-field value=testEmailAddress placeholderKey="admin.email.test_email_address"}}
+    <div class="controls">
+      <div class="inline-form">
+        {{#if sendingEmail}}
+          {{i18n "admin.email.sending_test"}}
+        {{else}}
+          {{text-field value=testEmailAddress placeholderKey="admin.email.test_email_address"}}
+          {{d-button
+            class="btn-primary"
+            action=(action "sendTestEmail")
+            disabled=sendTestEmailDisabled
+            label="admin.email.send_test"
+            type="submit"
+          }}
+          {{#if sentTestEmailMessage}}
+            <span class="result-message">{{sentTestEmailMessage}}</span>
+          {{/if}}
+        {{/if}}
       </div>
-      <div class="controls">
-        {{d-button
-          class="btn-primary"
-          action=(action "sendTestEmail")
-          disabled=sendTestEmailDisabled
-          label="admin.email.send_test"
-          type="submit"}}
-        {{#if sentTestEmailMessage}}<span class="result-message">{{sentTestEmailMessage}}</span>{{/if}}
-      </div>
-    {{/if}}
+    </div>
   </div>
 </form>
diff --git a/app/assets/javascripts/admin/addon/templates/email-preview-digest.hbs b/app/assets/javascripts/admin/addon/templates/email-preview-digest.hbs
index c93d048..a4af09f 100644
--- a/app/assets/javascripts/admin/addon/templates/email-preview-digest.hbs
+++ b/app/assets/javascripts/admin/addon/templates/email-preview-digest.hbs
@@ -2,32 +2,35 @@
 
 <div class="admin-controls email-preview">
   <div class="controls">
-    <label for="last-seen">{{i18n "admin.email.last_seen_user"}}</label>
-    {{date-picker-past value=lastSeen id="last-seen"}}
-    <label>{{i18n "admin.email.user"}}:</label>
-    {{email-group-user-chooser
-      value=username
-      onChange=(action "updateUsername")
-      options=(hash
-        maximum=1
-      )
-    }}
-    {{d-button
-      class="btn-primary digest-refresh-button"
-      action=(action "refresh")
-      label="admin.email.refresh"}}
-    <div class="toggle">
-      <label>{{i18n "admin.email.format"}}</label>
-      {{#if showHtml}}
-        <span>{{i18n "admin.email.html"}}</span>
-         |
-        <a href {{action "toggleShowHtml"}}>
-          {{i18n "admin.email.text"}}
-        </a>
-      {{else}}
-        <a href {{action "toggleShowHtml"}}>{{i18n "admin.email.html"}}</a> |
-        <span>{{i18n "admin.email.text"}}</span>
-      {{/if}}
+    <div class="inline-form">
+      <label for="last-seen">{{i18n "admin.email.last_seen_user"}}</label>
+      {{date-picker-past value=lastSeen id="last-seen"}}
+      <label>{{i18n "admin.email.user"}}:</label>
+      {{email-group-user-chooser
+        value=username
+        onChange=(action "updateUsername")
+        options=(hash
+          maximum=1
+        )
+      }}
+      {{d-button
+        class="btn-primary digest-refresh-button"
+        action=(action "refresh")
+        label="admin.email.refresh"
+      }}
+      <div class="toggle">
+        <label>{{i18n "admin.email.format"}}</label>
+        {{#if showHtml}}
+          <span>{{i18n "admin.email.html"}}</span>
+          |
+          <a href {{action "toggleShowHtml"}}>
+            {{i18n "admin.email.text"}}
+          </a>
+        {{else}}
+          <a href {{action "toggleShowHtml"}}>{{i18n "admin.email.html"}}</a> |
+          <span>{{i18n "admin.email.text"}}</span>
+        {{/if}}
+      </div>
     </div>
   </div>
 </div>
@@ -37,20 +40,22 @@
   <div class="email-preview-digest">
     {{#if showSendEmailForm}}
       <div class="controls">
-        {{#if sendingEmail}}
-          {{i18n "admin.email.sending_test"}}
-        {{else}}
-          <label>{{i18n "admin.email.send_digest_label"}}</label>
-          {{text-field value=email placeholderKey="admin.email.test_email_address"}}
-          {{d-button
-            class="btn-default"
-            action=(action "sendEmail")
-            disabled=sendEmailDisabled
-            label="admin.email.send_digest"}}
-          {{#if sentEmail}}
-            <span class="result-message">{{i18n "admin.email.sent_test"}}</span>
+        <div class="inline-form">
+          {{#if sendingEmail}}
+            {{i18n "admin.email.sending_test"}}
+          {{else}}
+            <label>{{i18n "admin.email.send_digest_label"}}</label>

[... diff too long, it was truncated ...]

GitHub sha: 24e71acf3f8be166083505b819c8c4d3c04694a9

This commit appears in #14226 which was approved by jjaffeux and CvX. It was merged by pmusaraj.

This commit has been mentioned on Discourse Meta. There might be relevant details there: