UX: remap native emojis in composer preview window properly. (PR #13525)

Currently, the native emojis like πŸ˜€ are remapped only after the server-side β€œpost” cooking. After this commit, it will get remapped in the composer preview window itself.

GitHub

  1. The spec failure looks valid?
  2. Is the performance impact not as severe as in the previous attempt?
  3. Could you add a test to components/d-editor-test.js to confirm live updates? :slightly_smiling_face:
  1. The spec failure looks valid?

@CvX yes, I’m checking it already.

2. Is the performance impact not as severe as in the previous attempt?

Thanks for the info. I will check the performance impact.

3. Could you add a test to components/d-editor-test.js to confirm live updates?

Sure :+1:

1 Like

I did the performance test and I can see a minor increase in the response time for every keystroke. @SamSaffron should we implement this minor improvement with this performance cost? Previously, you were really concerned about it here.

With my code

Screenshot 2021-07-02 071817 Screenshot 2021-07-02 071832

Without my code (in master branch)

Screenshot 2021-07-02 071759 Screenshot 2021-07-02 071735

cc @CvX

Yeah I am uneasy about the perf hit. I think the quality of life improvement is probably not worth it. It is likely to get even worse on very long posts :cry:

1 Like

Yes, I agree. Anyway, I already did the test with a very long post only.

1 Like