UX: removes superfluous posters column header (#6765)

UX: removes superfluous posters column header (#6765)
diff --git a/app/assets/javascripts/discourse/raw-views/topic-list-header-column.js.es6 b/app/assets/javascripts/discourse/raw-views/topic-list-header-column.js.es6
index e9af8e5..58cdc07 100644
--- a/app/assets/javascripts/discourse/raw-views/topic-list-header-column.js.es6
+++ b/app/assets/javascripts/discourse/raw-views/topic-list-header-column.js.es6
@@ -4,7 +4,7 @@ export default Ember.Object.extend({
       return this.forceName;
     }
 
-    return I18n.t(this.name);
+    return this.name ? I18n.t(this.name) : "";
   }.property(),
 
   sortIcon: function() {
diff --git a/app/assets/javascripts/discourse/templates/topic-list-header.raw.hbs b/app/assets/javascripts/discourse/templates/topic-list-header.raw.hbs
index 5bae677..54a7de6 100644
--- a/app/assets/javascripts/discourse/templates/topic-list-header.raw.hbs
+++ b/app/assets/javascripts/discourse/templates/topic-list-header.raw.hbs
@@ -7,7 +7,7 @@
 {{/if}}
 {{raw "topic-list-header-column" order='default' name=listTitle bulkSelectEnabled=bulkSelectEnabled showBulkToggle=toggleInTitle canBulkSelect=canBulkSelect}}
 {{#if showPosters}}
-  {{raw "topic-list-header-column" order='posters' name='users'}}
+  {{raw "topic-list-header-column" order='posters'}}
 {{/if}}
 {{raw "topic-list-header-column" sortable=sortable number='true' order='posts' name='replies'}}
 {{#if showParticipants}}

GitHub
sha: afdd2444

Sorry I am not following, what happened here? why the change?

That column title isn’t necessary, it’s ultra self explanatory, less words
= more better

2 Likes

I see… we did this:

Was not following directly from the commit.

I get the desire to reduce words but to me it feels like it leaves a bit of a hole here.

If we are going down this path … why are we keeping the word “Topic” ?

Are you … kidding? We constantly have to teach people that it is not
“thread”, it is “topic”. So yeah.

This is the one column whose header was totally and completely superfluous.

On Thu, Dec 13, 2018 at 6:07 PM Sam notifications@github.com wrote:

I see… we did this:

[image: image|690x150]

Was not following directly from the commit.

I get the desire to reduce words but to me it feels like it leaves a bit
of a hole here.

If we are going down this path … why are we keeping the word “Topic” ?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/discourse/discourse/commit/afdd244486fce1f1473d6af84f46d70e9e15eba4#commitcomment-31674361,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABc7VbB1xdWazYM2-ZJeOT22DkpnQOVcks5u4wfHgaJpZM4ZSrOL
.

When you create a new topic we say + New Topic we say it in tons of places in the UI.

Personally I would prefer just to suppress Topic here as well cause it is aesthetically more pleasing having “no col name”, “no col name”, “col names”, vs a chess board.

I think its would have probably been better to do this suppression in CSS cause it would be way easier to revert if any other people are disturbed by lack of column name. Post this change its quite a complex theme component to add it back in or trick :before CSS rule with content.

Anyway … we can wait on all of this and see how it unfolds.

I checked with Kris first and he agreed, so I think it’s fine. This column
title is really the only one that makes zero sense, it’s SUPER obvious what
it is…

Let’s compare the other columns:

  • Thread? Nope buddy, it’s Topic
  • What are these 3 numbers right next to each other?

Also “users” is kinda shitty language, I’d prefer “people” or
“participants” anyway. Users = drug users… it’s not great on the home
page. Plus it’s 100% redundant.

On Thu, Dec 13, 2018 at 6:51 PM Sam notifications@github.com wrote:

When you create a new topic we say + New Topic we say it in tons of
places in the UI.

Personally I would prefer just to suppress Topic here as well cause it is
aesthetically more pleasing having “no col name”, “no col name”, “col
names”, vs a chess board.

I think its would have probably been better to do this suppression in CSS
cause it would be way easier to revert if any other people are disturbed by
lack of column name. Post this change its quite a complex theme component
to add it back in or trick :before CSS rule with content.

Anyway … we can wait on all of this and see how it unfolds.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/discourse/discourse/commit/afdd244486fce1f1473d6af84f46d70e9e15eba4#commitcomment-31674560,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABc7VX8PILJLSYlKLodskVwgeVMUKbOHks5u4xJDgaJpZM4ZSrOL
.

2 Likes