We shouldn't be matching on the `created_at` field. Causes tests to randomly fail.

We shouldn’t be matching on the created_at field. Causes tests to randomly fail.

diff --git a/app/models/user_action.rb b/app/models/user_action.rb
index 69765c1..0d64a6c 100644
--- a/app/models/user_action.rb
+++ b/app/models/user_action.rb
@@ -176,7 +176,7 @@ LEFT JOIN categories c on c.id = t.category_id
 
   def self.remove_action!(hash)
     require_parameters(hash, :action_type, :user_id, :acting_user_id, :target_topic_id, :target_post_id)
-    if action = UserAction.where(hash).first
+    if action = UserAction.where(hash.except(:created_at)).first
       action.destroy
       MessageBus.publish("/user/#{hash[:user_id]}", {user_action_id: action.id, remove: true})
     end

GitHub sha: c753a3c7

1 Like