WIP: Use Lightgallery instead of Magnific Popup (PR #10846)



better use dataset here https://developer.mozilla.org/fr/docs/Web/API/HTMLElement/dataset

why next and not afterRender ?

is this a data-attribute ?

would we try to create a bundle with all of this so we load it in one go ?

scheduleOnce doesn’t work with an anonymous function, it would be called each time, either make it a dedicated function, or just use schedule

I tested this a bit and I don’t think it’s needed so I removed it.

I’ve changed it to schedule :+1:

It is, is there any additional information that you think I should add to that comment?

mostly you should be using dataset to get data attributes now

The following lines should be removed from client.en.yml.


The title of this pull request changed from “Use Lightgallery instead of Magnific Popup” to "WIP: Use Lightgallery instead of Magnific Popup